feat: Add ARN created roles as output #123
Conversation
…ture/add_arn_output # Conflicts: # README.md
* Add ARN created roles as output * terraform-docs: automated action * Rollback Readme.md * terraform-docs: automated action --------- Co-authored-by: HectorArchilogic <hector@archilogic.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
@Nekoshido thanks for the PR. I just merged and released 2.4.0. Interesting that the GH workflow was able to push the doc update to your fork. Did you make any special settings? |
Thank you for the fast response. I updated the README manually, not sure if it was that. |
|
Yeah I
I don't think so. Our GH PR check has a part where it updates parts of the readme with generated documentation about versions, variables and outputs. It pushed generated docs twice onto your PR branch. We had the case before where someone created a PR against main from a fork and our PR workflow was not able to push the generated doc onto the fork. This is why we came up with the fork_pr branch, where we can merge PRs even if the docs generation did not work. We then create a PR from fork_pr against main, whereupon docs are generated by the PR creation. Then we merge, thus preserving the original commits made by any contributors outside our org. So I wonder why our GH workflow was able to push to your fork... but nevermind, merging still went smoothly. |
No description provided.